gtk4.git
7 years agoslice model: Don't report excessive changes
Matthias Clasen [Sun, 6 Jan 2019 17:24:57 +0000 (12:24 -0500)]
slice model: Don't report excessive changes

We were not skipping an unchanged initial segment
of the slice in some cases. Fix that.

7 years agorbtree: Fix a crash in insertion fixup
Benjamin Otte [Sun, 20 Jan 2019 05:07:52 +0000 (06:07 +0100)]
rbtree: Fix a crash in insertion fixup

This got broken in commit a33ff4c6ab3a196b3c71da48e4e650da85d1691c.

Testcase included.

7 years agorbtree: Add a trivial way to add rbtree tests to the testsuite.
Benjamin Otte [Sun, 20 Jan 2019 05:06:18 +0000 (06:06 +0100)]
rbtree: Add a trivial way to add rbtree tests to the testsuite.

The format of the printout will be suitable for addition as a new test to
  testsuite/gtk/rbtree-crash.c
by just grepping the printouts from the relevant rbtree.

7 years agoMerge branch 'reference-include' into 'master'
Matthias Clasen [Sat, 19 Jan 2019 01:13:42 +0000 (01:13 +0000)]
Merge branch 'reference-include' into 'master'

Specify the C include for Unix printing API

See merge request GNOME/gtk!516

7 years agofilechoosernativeportal: stuff the current filter into options
Michael Catanzaro [Wed, 16 Jan 2019 01:51:00 +0000 (19:51 -0600)]
filechoosernativeportal: stuff the current filter into options

We need to tell the portal what filter is supposed to be selected by
default, or it will just pick the first one, which could be wrong and
annoying.

This will require updated xdg-desktop-portal and xdg-desktop-portal-gtk
to work properly.

Fixes #1492

7 years agofilechoosernativeportal: remove redundant casts
Michael Catanzaro [Tue, 15 Jan 2019 02:53:19 +0000 (20:53 -0600)]
filechoosernativeportal: remove redundant casts

We are casting from GtkFileChooserNative to... GtkFileChooserNative.
Boo.

7 years agofilechoosernative: forward current_filter to delegate dialog
Michael Catanzaro [Thu, 29 Nov 2018 21:34:17 +0000 (15:34 -0600)]
filechoosernative: forward current_filter to delegate dialog

gtk_file_chooser_set_filter() doesn't work for GtkFileChooserNative. The
code forwards added and removed filters to the delegate dialog, but
doesn't do anything to set the selected one, so the wrong one gets
chosen. So fix that.

This only fixes the fallback dialog. The portal will be fixed in a
subsequent commit.

Partial fix for #1492

7 years agoSpecify the C include for Unix printing API
Emmanuele Bassi [Sat, 19 Jan 2019 00:00:34 +0000 (00:00 +0000)]
Specify the C include for Unix printing API

Instead of using the INCLUDE directive inside the sections file, we can
specify the default C include in the gtkdoc-mkdb arguments, and override
it inside the C sources that need it.

7 years agoMerge branch 'master' into 'master'
Emmanuele Bassi [Fri, 18 Jan 2019 23:13:31 +0000 (23:13 +0000)]
Merge branch 'master' into 'master'

A11y: export gtk_cell_accessible_parent_get_(row|column)_header_cells

See merge request GNOME/gtk!505

7 years agoMerge branch 'switch-fallback' into 'master'
Matthias Clasen [Fri, 18 Jan 2019 22:43:54 +0000 (22:43 +0000)]
Merge branch 'switch-fallback' into 'master'

Add fallback glyphs for GtkSwitch states

See merge request GNOME/gtk!509

7 years agoabout dialog: Use ::activate-link for license
Matthias Clasen [Wed, 16 Jan 2019 04:16:16 +0000 (23:16 -0500)]
about dialog: Use ::activate-link for license

This should behave the same as all the other links
in this dialog.

Closes: #1561
7 years agogl renderer: Support (not) resetting the opacity for offscreen nodes
Timm Bäder [Fri, 18 Jan 2019 12:06:41 +0000 (13:06 +0100)]
gl renderer: Support (not) resetting the opacity for offscreen nodes

We usually want to do that, but it's wrong for e.g. crossfade nodes.

7 years agoentry: Use pango_layout_get_log_attrs_readonly
Timm Bäder [Fri, 18 Jan 2019 10:29:44 +0000 (11:29 +0100)]
entry: Use pango_layout_get_log_attrs_readonly

Since we're not modifying anything...

7 years agoentry: Use a label as placeholder
Timm Bäder [Fri, 18 Jan 2019 09:47:16 +0000 (10:47 +0100)]
entry: Use a label as placeholder

This gives us a better way of choosing the color of the placeholder text
(and enabled general css styling on it of course).

Closes #378 (If you want to keep the placeholder on focused and empty
entries, just don't set the placeholder opacity to 0 in
entry:focus>placeholder. This is the default behavior but this commit
includes a rule in Adwaita to hide it.

7 years agoentry: Trivial indentation fix
Timm Bäder [Fri, 18 Jan 2019 09:41:59 +0000 (10:41 +0100)]
entry: Trivial indentation fix

7 years agotooltip: Use gdk_rectangle_contains_point
Timm Bäder [Fri, 18 Jan 2019 08:28:03 +0000 (09:28 +0100)]
tooltip: Use gdk_rectangle_contains_point

7 years agotooltip: Move tooltips enabled checks into tooltips_enabled
Timm Bäder [Fri, 18 Jan 2019 08:16:44 +0000 (09:16 +0100)]
tooltip: Move tooltips enabled checks into tooltips_enabled

7 years agotooltip: Look at the event's target widget
Timm Bäder [Fri, 18 Jan 2019 07:48:07 +0000 (08:48 +0100)]
tooltip: Look at the event's target widget

Since we now have a widget whenever we query tooltips, we can as well
get the events target_widget if we have an event (which is what we do
when coming from gtkmain.c). This keeps us from searching the entire
widget hierarchy for the target event even though we've already done
that for pointing events in gtkmain.c

This reduced the work done in gtk_tooltip_handle_event in normal motion
events to basically nothing since we already did all the heavy lifting
when handling the pointing event in gtkmain.c

7 years agotooltip: Remove gtk_tooltip_trigger_tooltip_query
Timm Bäder [Fri, 18 Jan 2019 07:34:59 +0000 (08:34 +0100)]
tooltip: Remove gtk_tooltip_trigger_tooltip_query

As stated by the documentation, this should be called when a widget gets
updated, but in that case, one can equally use
gtk_widget_trigger_tooltip_query.

7 years agotooltips: Remove keyboard mode tooltips
Timm Bäder [Fri, 18 Jan 2019 07:27:28 +0000 (08:27 +0100)]
tooltips: Remove keyboard mode tooltips

Keyboard mode was only used in gtk_widget_real_show_help before, but now
that's gone and so is any usage of keyboard mode tooltips.

7 years agogizmo: return void from snapshot func
Timm Bäder [Fri, 18 Jan 2019 07:01:40 +0000 (08:01 +0100)]
gizmo: return void from snapshot func

This boolean return was from the old gadget code and we weren't using it
in the new gizmo code.

7 years agoscrolledwindow: Reset indicators in unmap()
Timm Bäder [Wed, 16 Jan 2019 13:24:59 +0000 (14:24 +0100)]
scrolledwindow: Reset indicators in unmap()

This is unrelated to any windowing resources these days, so no need for
an unrealize handler.

7 years agofilechooserwidget: Show spinner when searching
Timm Bäder [Thu, 17 Jan 2019 16:08:58 +0000 (17:08 +0100)]
filechooserwidget: Show spinner when searching

This was lost it seems

7 years agoGdkEvent: Make gdk_event_set_user_data private
Timm Bäder [Thu, 17 Jan 2019 16:02:49 +0000 (17:02 +0100)]
GdkEvent: Make gdk_event_set_user_data private

7 years agoGdkEvent: Remove unused struct
Timm Bäder [Thu, 17 Jan 2019 15:29:40 +0000 (16:29 +0100)]
GdkEvent: Remove unused struct

7 years agoGdkEvent: Add a proper user_data member to GdkEventAny
Timm Bäder [Thu, 17 Jan 2019 15:26:24 +0000 (16:26 +0100)]
GdkEvent: Add a proper user_data member to GdkEventAny

Setting it as qdata on the object doesn't save any memory since we use
the user_data as the event target, which every event has set these days.
This way is also faster since just reffing the object doesn't do any
locking.

7 years agoscrolledwindow: Fix a event widget/event target mixup
Timm Bäder [Thu, 17 Jan 2019 15:02:25 +0000 (16:02 +0100)]
scrolledwindow: Fix a event widget/event target mixup

7 years agoscrolledwindow: remove unused struct
Timm Bäder [Thu, 17 Jan 2019 15:02:13 +0000 (16:02 +0100)]
scrolledwindow: remove unused struct

7 years agoiconview: Fix scrolled drawing
Timm Bäder [Thu, 17 Jan 2019 14:55:57 +0000 (15:55 +0100)]
iconview: Fix scrolled drawing

We were only drawing the scrolled away first few items

7 years agogl renderer: Don't add clip ops if the clip didn't change
Timm Bäder [Thu, 17 Jan 2019 07:22:00 +0000 (08:22 +0100)]
gl renderer: Don't add clip ops if the clip didn't change

7 years agoswitch: Update state labels when needed
Emmanuele Bassi [Fri, 18 Jan 2019 14:43:42 +0000 (14:43 +0000)]
switch: Update state labels when needed

If the text style changes, or the display settings do, we need to update
the state labels to ensure that the glyphs are available in the font
we're using.

7 years agoMerge branch 'get-timings-transfer' into 'master'
Emmanuele Bassi [Wed, 16 Jan 2019 23:43:14 +0000 (23:43 +0000)]
Merge branch 'get-timings-transfer' into 'master'

g-i: Add transfer none annotations for frame clock timings getters

See merge request GNOME/gtk!511

7 years agog-i: Add transfer none annotations for frame clock timings getters
Tomasz Miąsko [Wed, 16 Jan 2019 00:00:00 +0000 (00:00 +0000)]
g-i: Add transfer none annotations for frame clock timings getters

7 years agocolorscale: Redraw correct widget after setting rgba
Timm Bäder [Wed, 16 Jan 2019 18:20:53 +0000 (19:20 +0100)]
colorscale: Redraw correct widget after setting rgba

The entire color scale hack is still done in GtkRange, which draws the
color scale in the range gizmo. So, to correctly redraw the color scale
when setting a new color, we need to redraw the proper widget and that's
the trough widget.

Fixes #1453

7 years agoentry: Remove _gtk_entry_grab_focus
Timm Bäder [Wed, 16 Jan 2019 18:16:47 +0000 (19:16 +0100)]
entry: Remove _gtk_entry_grab_focus

We have API for both the select and !select behavior these days, so use
that one.

Fixes #1457

7 years agowindow: Directly find the cursor in the widget hierarchy
Timm Bäder [Wed, 16 Jan 2019 16:37:42 +0000 (17:37 +0100)]
window: Directly find the cursor in the widget hierarchy

Instead of recording the way up from the target widget to the grab
widget (or toplevel) and then walking that path upwards, just walk the
parent chain and look at the cursor.

7 years agoscrolledwindow: Remove unused drag_device member
Timm Bäder [Wed, 16 Jan 2019 09:55:15 +0000 (10:55 +0100)]
scrolledwindow: Remove unused drag_device member

7 years agosnapshot: Add gtk_snapshot_from_parent
Timm Bäder [Wed, 16 Jan 2019 07:30:42 +0000 (08:30 +0100)]
snapshot: Add gtk_snapshot_from_parent

Most of the time, the GtkSnapshot objects we create while snapshotting
widgets don't end up containing all that many nodes or states in their
respective node or state stack. This undermines the amortized allocation
behavior of the G(Ptr)Array we use for the stacks. So instead, use the
(until now unused) parent_snapshot GtkSnapshot* passed to
gtk_widget_create_render_node and reuse its node and state stack.

We do not avoid allocating a new GtkSnapshot object, but we do avoid
allocating a ton of G(Ptr)Array objects and we also avoid realloc'ing
their storage.

7 years agowindow: Don't manually queue a draw on the new focus widget
Timm Bäder [Tue, 15 Jan 2019 05:11:03 +0000 (06:11 +0100)]
window: Don't manually queue a draw on the new focus widget

This is either unneeded and OK to remove, or it is needed and there's a
bug somewhere else.

7 years agotreeview: Don't get separator_height more than once
Timm Bäder [Tue, 15 Jan 2019 15:26:13 +0000 (16:26 +0100)]
treeview: Don't get separator_height more than once

Closes !209

7 years agotreeview: cache expander size
Timm Bäder [Tue, 15 Jan 2019 15:23:18 +0000 (16:23 +0100)]
treeview: cache expander size

We need to know it all the time and since we get it from CSS, doing that
is fairly expensive.

7 years agoUpdated Spanish translation
Daniel Mustieles [Wed, 16 Jan 2019 08:54:54 +0000 (09:54 +0100)]
Updated Spanish translation

7 years agoAdd fallback glyphs for GtkSwitch states
Emmanuele Bassi [Tue, 15 Jan 2019 22:16:05 +0000 (22:16 +0000)]
Add fallback glyphs for GtkSwitch states

Even though the IEC power glyphs are part of Unicode 9.0 (released in
2016) not all fonts have them.

To avoid showing the hexbox of doom when the system font does not have
the glyphs we'd like to use, add a fallback pair, using the old glyphs
we suggested when the labels were translatable.

7 years agoUpdate Esperanto translation
Carmen Bianca BAKKER [Mon, 14 Jan 2019 21:16:22 +0000 (21:16 +0000)]
Update Esperanto translation

7 years agorbtree: Fix removing last element
Benjamin Otte [Mon, 14 Jan 2019 17:42:18 +0000 (18:42 +0100)]
rbtree: Fix removing last element

The refactoring of automatically updating tree->root when setting a
node's parent works very well - unless all nodes get removed and no
node's parent got updated.

7 years agorbtree: Make node getters not require tree argument
Benjamin Otte [Mon, 14 Jan 2019 01:12:02 +0000 (02:12 +0100)]
rbtree: Make node getters not require tree argument

The tree is not needed to walk around the nodes.

It is however still needed for anything that requires modifying the
tree.

There is no immediate benefit in changing this API, but there might be
situations in the future where we can avoid looking up the tree when we
just want to check some details about the node.

7 years agorbtree: Add gtk_rb_tree_node_get_tree()
Benjamin Otte [Mon, 14 Jan 2019 00:55:23 +0000 (01:55 +0100)]
rbtree: Add gtk_rb_tree_node_get_tree()

Store a link to the tree in the root node. This allows looking up the
tree in O(log N) from the node without any extra memory usage.

This is useful because code can just store a pointer to the node and
doesn't need to keep the tree pointer around. And that can (for large
trees) save quite a bit of memory.

7 years agorbtree: Access node->parent only via accessors
Benjamin Otte [Mon, 14 Jan 2019 00:44:07 +0000 (01:44 +0100)]
rbtree: Access node->parent only via accessors

This also adds a set_parent() function that automatically takes care of
updating tree->root for root nodes.

7 years agorbtree: Remove gtk_rb_tree_find()
Benjamin Otte [Sat, 12 Jan 2019 14:09:37 +0000 (15:09 +0100)]
rbtree: Remove gtk_rb_tree_find()

Searching through the tree is too specific to use a general function.
All the existing code just copies and slightly adapts the same 20 lines
instead, so there's no reason to keep the complicated API.

7 years agoRename GtkCssRBTree to GtkRBTree
Matthias Clasen [Mon, 7 Jan 2019 04:37:32 +0000 (23:37 -0500)]
Rename GtkCssRBTree to GtkRBTree

This is a generally usable red-black tree api,
and it is not used in css at all.

7 years agoRename GtkRBTree to GtkTreeRBTree
Matthias Clasen [Mon, 7 Jan 2019 03:28:09 +0000 (22:28 -0500)]
Rename GtkRBTree to GtkTreeRBTree

This frees up the generic name for a more
generic rbtree implementation.

7 years agogl renderer: Force blur shadow node children offscreen
Timm Bäder [Sun, 13 Jan 2019 07:21:58 +0000 (08:21 +0100)]
gl renderer: Force blur shadow node children offscreen

This broke the overlay blur demoe when resizing the window to a size
that would completely move the image below a button, causing the
GtkSnapshot code to remove the clip node below the blur node.

7 years agooverlay: Directly create cairo_region
Timm Bäder [Sun, 13 Jan 2019 06:47:53 +0000 (07:47 +0100)]
overlay: Directly create cairo_region

Instead of doing a cairo_region_create + union, just pass the rect
directly to cairo_region_create_rectangle

7 years agorendernodepaintable: Don't try to snapshot 0×0 nodes
Timm Bäder [Sun, 13 Jan 2019 06:23:10 +0000 (07:23 +0100)]
rendernodepaintable: Don't try to snapshot 0×0 nodes

Considering the operations that some of the rendernode constructors
do, nodes with width or height 0 (or both of course) are very well
possible. This would break in the rendernodepaintable when adding a
transform, which divides by width/height of the rendernode.

7 years agooverlay: Blur the clipped node, not clip the blurred node
Timm Bäder [Sun, 13 Jan 2019 05:35:44 +0000 (06:35 +0100)]
overlay: Blur the clipped node, not clip the blurred node

Blurring is a lot more expensive than clipping, so try to blur less by
clipping first.

7 years agooverlay: Trivial indentation fix
Timm Bäder [Sun, 13 Jan 2019 04:49:26 +0000 (05:49 +0100)]
overlay: Trivial indentation fix

7 years agodemo: Fix tranparency overlay demo
Timm Bäder [Sun, 13 Jan 2019 04:46:06 +0000 (05:46 +0100)]
demo: Fix tranparency overlay demo

We'd like the rose picture to be bigger than 16×16. Also remove the
scrolledwindow since the GtkPicture now automatically scales down the
rose image. This also fixes the picture always being allocated at y=0.

7 years agooverlay: Don't offset the main window snapshot
Timm Bäder [Sun, 13 Jan 2019 04:41:43 +0000 (05:41 +0100)]
overlay: Don't offset the main window snapshot

We need the node without an offset applied.

Fixes the rose picture being offset in tests/testoverlay

7 years agotestoverlay: Re-enable blurring
Timm Bäder [Sun, 13 Jan 2019 04:28:44 +0000 (05:28 +0100)]
testoverlay: Re-enable blurring

Accidentally disabled in 8b14c8d0a820e6617bd72a39a53d2ae6fa7b242b

7 years agolabel: Add missing nullable annotation
Timm Bäder [Sat, 12 Jan 2019 07:03:47 +0000 (08:03 +0100)]
label: Add missing nullable annotation

7 years agoUpdate Polish translation
Piotr Drąg [Sat, 12 Jan 2019 12:19:35 +0000 (13:19 +0100)]
Update Polish translation

7 years agoA11y: export gtk_cell_accessible_parent_get_(row|column)_header_cells
Mike Gorse [Fri, 11 Jan 2019 22:21:21 +0000 (16:21 -0600)]
A11y: export gtk_cell_accessible_parent_get_(row|column)_header_cells

These functions were missing GDK_AVAILABLE_IN macros, so they were
listed in the gir but not exported.

7 years agospinbutton: Use increment/decrement icon names
Timm Bäder [Fri, 11 Jan 2019 17:17:08 +0000 (18:17 +0100)]
spinbutton: Use increment/decrement icon names

And add list-{remove,add}-symbolic as fallback.

Fixes #1569

7 years agolabel: Skip updating link state if we have no layout
Timm Bäder [Fri, 11 Jan 2019 16:46:12 +0000 (17:46 +0100)]
label: Skip updating link state if we have no layout

This can happen whenever the ::activate-link handler sets different
markup on the label, causing all links to be recreated. In this case,
the GtkLabelLink* passed to emit_activate_link is garbage after the
g_signal_emit call and we shouldn't try to do anything with it.

Fixes #1498

7 years agosnapshot: Get new GArray item directly
Timm Bäder [Fri, 11 Jan 2019 09:05:44 +0000 (10:05 +0100)]
snapshot: Get new GArray item directly

Instead of building it up ourselves, then coping it into the GArray and
then getting the last element of that array.

7 years agoUse the IEC power symbols for GtkSwitch labels
Emmanuele Bassi [Fri, 11 Jan 2019 15:21:09 +0000 (15:21 +0000)]
Use the IEC power symbols for GtkSwitch labels

Unicode 9.0 introduced glyps for the "on" and "off" power states, in the
form of:

 - U+23FD POWER ON SYMBOL, or ⏽
 - U+2B58 HEAVY CIRCLE, or ⭘

With `HEAVY CIRCLE` as "power off symbol" selected to avoid adding yet
another circle to the standard.

Since we moved GtkSwitch to always show glyphs instead of (translatable)
strings, asking the localisation teams to either come up with a suitable
short string to replace the English "ON" and "OFF", or to fall back to
Unicode glyphs, we should ensure we're using the appropriate symbols to
begin with.

See also: gtk!503 for the corresponding gtk-3-24 change.

7 years agoMerge branch 'wip/muktupavels/listbox-master' into 'master'
Timm Bäder [Fri, 11 Jan 2019 11:38:27 +0000 (11:38 +0000)]
Merge branch 'wip/muktupavels/listbox-master' into 'master'

listbox: set selected_row before emitting signal

See merge request GNOME/gtk!502

7 years agolistbox: set selected_row before emitting signal
Alberts Muktupāvels [Tue, 1 Jan 2019 23:14:17 +0000 (01:14 +0200)]
listbox: set selected_row before emitting signal

Signal emittion was added in 6f857f87dcd9 commit and it seems that
this is only place where selected_row is set after emitting signal.

Because of this gtk_list_box_get_selected_row currently returns NULL
as selected row if selection mode is set to GTK_SELECTION_BROWSE.

7 years agoMerge branch 'wip/dboles/EventControllerKey-docs-4' into 'master'
Timm Bäder [Fri, 11 Jan 2019 09:39:25 +0000 (09:39 +0000)]
Merge branch 'wip/dboles/EventControllerKey-docs-4' into 'master'

EventControllerKey: Add missing documentation bits

See merge request GNOME/gtk!454

7 years agoswitch: Always use I/O
Matthias Clasen [Thu, 10 Jan 2019 22:20:45 +0000 (17:20 -0500)]
switch: Always use I/O

This allows for smaller switches, and goes better with
modern themes that have round switches.

7 years agogl renderer: Dont't try to draw glyphs at scale 0
Timm Bäder [Thu, 10 Jan 2019 16:14:48 +0000 (17:14 +0100)]
gl renderer: Dont't try to draw glyphs at scale 0

Fixes #1475

7 years agogl glyphcache: Only support one dirty glyph per atlas
Timm Bäder [Sun, 6 Jan 2019 14:35:54 +0000 (15:35 +0100)]
gl glyphcache: Only support one dirty glyph per atlas

7 years agotestoverlay: Fix fancy effect
Timm Bäder [Sun, 6 Jan 2019 14:05:25 +0000 (15:05 +0100)]
testoverlay: Fix fancy effect

7 years agoiconcache: Remove unused defines
Timm Bäder [Sun, 6 Jan 2019 10:08:09 +0000 (11:08 +0100)]
iconcache: Remove unused defines

7 years agogl renderer: Remove debug code
Timm Bäder [Sun, 6 Jan 2019 09:59:21 +0000 (10:59 +0100)]
gl renderer: Remove debug code

7 years agogl renderer: Fix hidpi transform nodes
Timm Bäder [Sun, 6 Jan 2019 09:59:01 +0000 (10:59 +0100)]
gl renderer: Fix hidpi transform nodes

7 years agoshadowvalue: Remove unused API
Timm Bäder [Sat, 5 Jan 2019 08:09:58 +0000 (09:09 +0100)]
shadowvalue: Remove unused API

7 years agogl renderer: Only compile the vertex shader once
Timm Bäder [Sun, 6 Jan 2019 05:55:31 +0000 (06:55 +0100)]
gl renderer: Only compile the vertex shader once

All our programs use the same vertex shader, so don't compile it over
and over again. This improves startup times by at least 0.001%, I swear.

7 years agogl renderer: Don't forget the offset when rendering blur nodes
Timm Bäder [Sat, 5 Jan 2019 08:18:27 +0000 (09:18 +0100)]
gl renderer: Don't forget the offset when rendering blur nodes

7 years agoUpdate Spanish translation
Daniel Mustieles [Thu, 10 Jan 2019 08:50:55 +0000 (08:50 +0000)]
Update Spanish translation

7 years agoMerge branch 'patch-1' into 'master'
Timm Bäder [Thu, 10 Jan 2019 06:23:09 +0000 (06:23 +0000)]
Merge branch 'patch-1' into 'master'

Fix a typo in “popup-context-menu” documentation.

See merge request GNOME/gtk!500

7 years agoFix a typo in “popup-context-menu” documentation.
bodqhrohro [Wed, 9 Jan 2019 14:24:29 +0000 (14:24 +0000)]
Fix a typo in “popup-context-menu” documentation.

7 years agoMerge branch 'wip/sadiq/750-gtk4' into 'master'
Timm Bäder [Wed, 9 Jan 2019 11:53:45 +0000 (11:53 +0000)]
Merge branch 'wip/sadiq/750-gtk4' into 'master'

gtkpopover: Fix popover when parent widget is partially visible

Closes #750

See merge request GNOME/gtk!496

7 years agogtkpopover: Fix popover when parent widget is partially visible
Mohammed Sadiq [Wed, 9 Jan 2019 11:06:06 +0000 (16:36 +0530)]
gtkpopover: Fix popover when parent widget is partially visible

fixes https://gitlab.gnome.org/GNOME/gtk/issues/750

7 years agoUpdated Spanish translation
Daniel Mustieles [Wed, 9 Jan 2019 08:52:53 +0000 (09:52 +0100)]
Updated Spanish translation

7 years agoMerge branch 'meson-warning' into 'master'
Emmanuele Bassi [Tue, 8 Jan 2019 14:59:21 +0000 (14:59 +0000)]
Merge branch 'meson-warning' into 'master'

build: Avoid a Meson deprecation warning

See merge request GNOME/gtk!493

7 years agobuild: Avoid a Meson deprecation warning
Emmanuele Bassi [Tue, 8 Jan 2019 14:46:46 +0000 (14:46 +0000)]
build: Avoid a Meson deprecation warning

Using an empty `configuration_data` object to copy a configuration file
is deprecated since Meson 0.47 (released July 2018); the equivalent
behaviour is available by using `copy: true`.

7 years agorevealer: Handle child-visible properly
Benjamin Otte [Tue, 8 Jan 2019 00:29:41 +0000 (01:29 +0100)]
revealer: Handle child-visible properly

The target position is irrelevant for determining if the child should be
visible. When the current position is 0, it needs to be hidden, period.

Fixes #1355

7 years agosettings: Don't special case IM modules
Benjamin Otte [Mon, 7 Jan 2019 23:39:15 +0000 (00:39 +0100)]
settings: Don't special case IM modules

The previous fixes made it unnecessary to hardcode IM modules for
different display types. The code now automatically skips system IM
modules for other displays.

7 years agoimmodule: Check if module matches display
Benjamin Otte [Mon, 7 Jan 2019 23:36:58 +0000 (00:36 +0100)]
immodule: Check if module matches display

When loading IM modules from environment variables or GtkSettings, we
would accept "xim" on Wayland. That is a bad idea.

7 years agoimmodule: Don't load unsupported IM module
Benjamin Otte [Mon, 7 Jan 2019 23:25:08 +0000 (00:25 +0100)]
immodule: Don't load unsupported IM module

The code would technically allow loading the xim module when X11 support
was not compiled in.

This is probably an artificial concern, because it's pretty hard to
compile XIM support without X11 support, but it makes the code clearer,
so there we go.

7 years agoimmodule: Pass a GdkDisplay for default context ID
Benjamin Otte [Mon, 7 Jan 2019 23:22:14 +0000 (00:22 +0100)]
immodule: Pass a GdkDisplay for default context ID

After all, the context depends on the display - we want to use the
wayland context for Wayland,  xim for X11 and so on.

7 years agoimmulticontext: Don't have a global_context_id
Benjamin Otte [Mon, 7 Jan 2019 23:16:52 +0000 (00:16 +0100)]
immulticontext: Don't have a global_context_id

Context IDs are dependant on the display - both because displays can use
different backends, but also because changing the GtkSetting is a
per-display operation.

So just remove the cache.
If it turns out we need a per-display cache, we can add one to
GtkSettings.

7 years agoa11y: Check display in `*grab_cell_focus()`
Olivier Fourdan [Mon, 7 Jan 2019 21:06:57 +0000 (21:06 +0000)]
a11y: Check display in `*grab_cell_focus()`

Calling the accessibility function `grab_focus()` on a `GtkCell` under
Wayland will cause the client to crash.

This is another case of `gdk_x11_get_server_time()` being called
regardless of the actual windowing backend used.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1507
7 years agoflowbox: Accept multipress gesture late
Carlos Garnacho [Wed, 2 Jan 2019 18:10:49 +0000 (19:10 +0100)]
flowbox: Accept multipress gesture late

So it's able to operate properly with the DnD gesture set by
gtk_drag_source_set(). We usually just react on button release,
that's the right time to claim the gesture.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1557
7 years agosearchenginequartz: Fix naming of Beagle @ comment
Daniel Boles [Mon, 7 Jan 2019 20:34:32 +0000 (20:34 +0000)]
searchenginequartz: Fix naming of Beagle @ comment

As funny as that is, it's not very instructive. :P

https://gitlab.gnome.org/GNOME/gtk/merge_requests/490#note_400993

7 years ago[GtkSearchEngineQuartz] Limit the returned hits.
John Ralls [Mon, 7 Jan 2019 00:19:49 +0000 (16:19 -0800)]
[GtkSearchEngineQuartz] Limit the returned hits.

When the result set is larger than the limit.

7 years ago[GtkSearchEngineQuartz] Resolve the path to a GtkFile* for the hit list.
Daniel Boles [Sun, 6 Jan 2019 23:56:57 +0000 (15:56 -0800)]
[GtkSearchEngineQuartz] Resolve the path to a GtkFile* for the hit list.

Instead of a char* path, which the search_hit parser doesn't expect,
causing a crash.

Closes: $https://gitlab.gnome.org/GNOME/gtk/issues/815
7 years agoMerge branch 'fix-corner-resize' into 'master'
Carlos Garnacho [Mon, 7 Jan 2019 18:14:33 +0000 (18:14 +0000)]
Merge branch 'fix-corner-resize' into 'master'

Fix resize corners

See merge request GNOME/gtk!481

7 years agoMerge branch 'commit-docs' into 'master'
Matthias Clasen [Mon, 7 Jan 2019 16:44:41 +0000 (16:44 +0000)]
Merge branch 'commit-docs' into 'master'

docs: Move commit style docs to the contribution guide

See merge request GNOME/gtk!358